[PATCH] Fix constant folding for one lane vectors (PR15611)

Bob Wilson bob.wilson at apple.com
Wed Apr 24 22:15:31 PDT 2013


This looks good to me.

On Apr 22, 2013, at 3:59 AM, Silviu Baranga <silbar01 at arm.com> wrote:

> Ping!
> 
> - Silviu
> 
>> -----Original Message-----
>> From: Silviu Baranga [mailto:silbar01 at arm.com]
>> Sent: 12 April 2013 15:29
>> To: llvm-commits at cs.uiuc.edu
>> Subject: [PATCH] Fix constant folding for one lane vectors (PR15611)
>> 
>> Hi,
>> 
>> The attached patch fixes constant folding for one lane vectors,
>> which is the root cause for PR15611. The faulty code path is
>> taken by scalarizing vector code during type legalization.
>> 
>> The constant folding code will currently return a scalar when
>> taking one lane input vectors, which can cause an assertion failure
>> later.
>> 
>> The changed code was wrong because if the size of the output vector
>> is 1, we can still be in the case where we need to return a one lane
>> vector.
>> 
>> Please review!
>> 
>> Thanks,
>> Silviu
> <v1-constant-fold.diff>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130424/c70e33d2/attachment.html>


More information about the llvm-commits mailing list