<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">This looks good to me.<div><br><div><div>On Apr 22, 2013, at 3:59 AM, Silviu Baranga <<a href="mailto:silbar01@arm.com">silbar01@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Ping!<br><br>- Silviu<br><br><blockquote type="cite">-----Original Message-----<br>From: Silviu Baranga [<a href="mailto:silbar01@arm.com">mailto:silbar01@arm.com</a>]<br>Sent: 12 April 2013 15:29<br>To:<span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>Subject: [PATCH] Fix constant folding for one lane vectors (PR15611)<br><br>Hi,<br><br>The attached patch fixes constant folding for one lane vectors,<br>which is the root cause for PR15611. The faulty code path is<br>taken by scalarizing vector code during type legalization.<br><br>The constant folding code will currently return a scalar when<br>taking one lane input vectors, which can cause an assertion failure<br>later.<br><br>The changed code was wrong because if the size of the output vector<br>is 1, we can still be in the case where we need to return a one lane<br>vector.<br><br>Please review!<br><br>Thanks,<br>Silviu</blockquote><span><v1-constant-fold.diff></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>