[llvm] r178319 - Revert r178166. According to Howard, this code is actually ok.

[David Blaikie]

On Mar 29, 2013 11:16 AM, "Dan Gohman" <dan433584 at gmail.com> wrote:
>
> Author: djg
> Date: Thu Mar 28 19:13:08 2013
> New Revision: 178319
>
> URL: http://llvm.org/viewvc/llvm-project?rev=178319&view=rev
> Log:
> Revert r178166. According to Howard, this code is actually ok.

Well. It's technically correct according to the standard, but do we know
how well the standard is implemented in the implementations wee care about?
I believe this was found as a bug when using at least one version of
libstdc++...

>
> Modified:
>     llvm/trunk/utils/TableGen/CodeGenSchedule.cpp
>
> Modified: llvm/trunk/utils/TableGen/CodeGenSchedule.cpp
> URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenSchedule.cpp?rev=178319&r1=178318&r2=178319&view=diff
>
==============================================================================
> --- llvm/trunk/utils/TableGen/CodeGenSchedule.cpp (original)
> +++ llvm/trunk/utils/TableGen/CodeGenSchedule.cpp Thu Mar 28 19:13:08 2013
> @@ -1105,9 +1105,7 @@ void PredTransitions::getIntersectingVar
>        // Push another copy of the current transition for more variants.
>        Variant.TransVecIdx = TransVec.size();
>        IntersectingVariants.push_back(Variant);
> -
> -      PredTransition Trans = TransVec[TransIdx];
> -      TransVec.push_back(Trans);
> +      TransVec.push_back(TransVec[TransIdx]);
>      }
>    }
>  }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130417/5c149202/attachment.html>