<p dir="ltr"><br>
On Mar 29, 2013 11:16 AM, "Dan Gohman" <<a href="mailto:dan433584@gmail.com">dan433584@gmail.com</a>> wrote:<br>
><br>
> Author: djg<br>
> Date: Thu Mar 28 19:13:08 2013<br>
> New Revision: 178319<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=178319&view=rev">http://llvm.org/viewvc/llvm-project?rev=178319&view=rev</a><br>
> Log:<br>
> Revert r178166. According to Howard, this code is actually ok.</p>
<p dir="ltr">Well. It's technically correct according to the standard, but do we know how well the standard is implemented in the implementations wee care about? I believe this was found as a bug when using at least one version of libstdc++...</p>

<p dir="ltr">><br>
> Modified:<br>
>     llvm/trunk/utils/TableGen/CodeGenSchedule.cpp<br>
><br>
> Modified: llvm/trunk/utils/TableGen/CodeGenSchedule.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenSchedule.cpp?rev=178319&r1=178318&r2=178319&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenSchedule.cpp?rev=178319&r1=178318&r2=178319&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/utils/TableGen/CodeGenSchedule.cpp (original)<br>
> +++ llvm/trunk/utils/TableGen/CodeGenSchedule.cpp Thu Mar 28 19:13:08 2013<br>
> @@ -1105,9 +1105,7 @@ void PredTransitions::getIntersectingVar<br>
>        // Push another copy of the current transition for more variants.<br>
>        Variant.TransVecIdx = TransVec.size();<br>
>        IntersectingVariants.push_back(Variant);<br>
> -<br>
> -      PredTransition Trans = TransVec[TransIdx];<br>
> -      TransVec.push_back(Trans);<br>
> +      TransVec.push_back(TransVec[TransIdx]);<br>
>      }<br>
>    }<br>
>  }<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>