[llvm] r179285 - Add a function to check if an argument list is too long.

[Rafael Espíndola]

> And that it compiles.
>
> But what about just choosing a value that is 10x larger than any OS
> supports? It doesn't have to be terribly precise.

On linux I think that is half of your stack space, so that would be a
fairly expensive unit test.

>>
>> That is why my suggestion is to just test that the clang driver works
>> when given a large command line. It might work because the system it
>> is running in has a really large limit (current linux for example) or
>> because it is creating an @file.
>
>
> I don't see how this will be easier than a unit test...

It is not easier, but
* We will have to do something to test the clang side.
* It tests what the user really wants: i.e.: the driver can invoke the
subcommand.

The one thing it will not catch is this function becoming redundant
the day all supported OSs have large command line support.

Cheers,
Rafael