[llvm] r179285 - Add a function to check if an argument list is too long.

[Chandler Carruth]

On Thu, Apr 11, 2013 at 9:35 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> > Please include unittests for things under Support where possible. This
> one
> > seems quite easy.
>
> How? The interesting part of this function is its connection to the OS
> (the call to sysconf or the value copied from the windows doc). We can
> stub that, but then the test is just that the function adds the size
> of each argument.
>

And that it compiles.

But what about just choosing a value that is 10x larger than any OS
supports? It doesn't have to be terribly precise.


> That is why my suggestion is to just test that the clang driver works
> when given a large command line. It might work because the system it
> is running in has a really large limit (current linux for example) or
> because it is creating an @file.
>

I don't see how this will be easier than a unit test...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130411/9b37e29d/attachment.html>