[lld] r177392 - Add virtual destructors to fix -Wnon-virtual-dtor warnings

Alexey Samsonov samsonov at google.com
Tue Mar 19 04:41:17 PDT 2013


Author: samsonov
Date: Tue Mar 19 06:41:16 2013
New Revision: 177392

URL: http://llvm.org/viewvc/llvm-project?rev=177392&view=rev
Log:
Add virtual destructors to fix -Wnon-virtual-dtor warnings

Modified:
    lld/trunk/include/lld/ReaderWriter/LinkerScript.h
    lld/trunk/lib/ReaderWriter/ELF/TargetHandler.h

Modified: lld/trunk/include/lld/ReaderWriter/LinkerScript.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/LinkerScript.h?rev=177392&r1=177391&r2=177392&view=diff
==============================================================================
--- lld/trunk/include/lld/ReaderWriter/LinkerScript.h (original)
+++ lld/trunk/include/lld/ReaderWriter/LinkerScript.h Tue Mar 19 06:41:16 2013
@@ -82,6 +82,8 @@ public:
 
   virtual void dump(llvm::raw_ostream &os) const = 0;
 
+  virtual ~Command() {}
+
 protected:
   Command(Kind k) : _kind(k) {}
 

Modified: lld/trunk/lib/ReaderWriter/ELF/TargetHandler.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/TargetHandler.h?rev=177392&r1=177391&r2=177392&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/TargetHandler.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/TargetHandler.h Tue Mar 19 06:41:16 2013
@@ -65,6 +65,8 @@ public:
   virtual int64_t getType(const Elf_Sym *sym) const {
     return llvm::ELF::STT_NOTYPE;
   }
+
+  virtual ~TargetAtomHandler() {}
 };
 
 template <class ELFT> class TargetRelocationHandler {
@@ -74,6 +76,8 @@ public:
                   const Reference &)const = 0;
 
   virtual int64_t relocAddend(const Reference &)const { return 0; }
+
+  virtual ~TargetRelocationHandler() {}
 };
 
 /// \brief An interface to override functions that are provided by the





More information about the llvm-commits mailing list