supposed vector data types support in the LLVM interpreter

Nadav Rotem nrotem at apple.com
Fri Mar 15 11:10:57 PDT 2013


Hi Yuri, 

Thanks for working on this. Can you please reformat the code according to the LLVM coding style. For example, braces need to be on the same line as the IFs, no need for braces if you have a single statement, period at end of comments, default switch cases should be on top. Can you move std::vector to small vector ? I understand that you are working on windows, but can you please keep the current eol svn property ?

Thanks,
Nadav

On Mar 15, 2013, at 7:57 AM, "Veselov, Yuri" <Yuri.Veselov at intel.com> wrote:

> Hi,
> My name is Yuri, I work in Intel’s OpenCL project, we use LLVM , and in particular, LLVM interpreter.
> We added to the interpreter support for vector data types, according to the OpenCL needs.
>  
> I think I will not be a frequent contributor to LLVM, but I would like to provide this interpreter’senhancement by several patches, thirst of them is attached –
> it includes support for vector load/store operations, getting constant value for vectors, ‘extractelement’ instruction and simple test.
>  
> So, I would like to pass the code review with attached pass.
>  
> Should I request an account on the Phabricator?
> Best regards,
> Yuri Veselov
> INNL, Nizhny Novgorod, Russia
> '+7(831)296-94-44;ext.2307
> *Yuri.Veselov at Intel.com
>  
> 
> --------------------------------------------------------------------
> Closed Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park, 
> 17 Krylatskaya Str., Bldg 4, Moscow 121614, 
> Russian Federation
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 
> <interpreter_patch.diff>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130315/0a0ee757/attachment.html>


More information about the llvm-commits mailing list