<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Yuri, <div><br></div><div>Thanks for working on this. Can you please reformat the code according to the LLVM coding style. For example, braces need to be on the same line as the IFs, no need for braces if you have a single statement, period at end of comments, default switch cases should be on top. Can you move std::vector to small vector ? I understand that you are working on windows, but can you please keep the current eol svn property ?</div><div><br></div><div>Thanks,</div><div>Nadav</div><div><br><div><div>On Mar 15, 2013, at 7:57 AM, "Veselov, Yuri" <<a href="mailto:Yuri.Veselov@intel.com">Yuri.Veselov@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div lang="RU" link="blue" vlink="purple" style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><div class="WordSection1" style="page: WordSection1;"><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US">Hi,<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US">My name is Yuri, I work in Intel’s OpenCL project, we use LLVM , and in particular, LLVM interpreter.<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US">We added to the interpreter support for vector data types, according to the OpenCL needs.<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US"> </span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US">I think I will not be a frequent contributor to LLVM, but I would like to provide this interpreter’s</span><span style="font-size: 9pt; font-family: Verdana, sans-serif;"><a href="http://lingvopro.abbyyonline.com/ru/Search/GlossaryItemExtraInfo?text=%d1%80%d0%b0%d1%81%d1%88%d0%b8%d1%80%d0%b5%d0%bd%d0%b8%d0%b5&translation=enhancement&srcLang=ru&destLang=en" title="Показать примеры употребления" style="color: purple; text-decoration: underline;"><span class="translation"><span lang="EN-US" style="text-decoration: none;">enhancement</span></span></a></span><span class="Apple-converted-space"> </span><span lang="EN-US">by several patches, thirst of them is attached –<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US">it includes support for vector load/store operations, getting constant value for vectors, ‘extractelement’ instruction and simple test.<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US"> </span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US">So, I would like to pass the code review with attached pass.<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US"> </span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US">Should I request an account on the Phabricator?<o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US"><o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt 8.5pt; font-size: 11pt; font-family: Calibri, sans-serif;"><b><span lang="EN-US" style="font-size: 10pt; font-family: 'Times New Roman', serif; color: navy;">Best regards,</span></b><span lang="EN-US" style="font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt 8.5pt; font-size: 11pt; font-family: Calibri, sans-serif;"><b><span lang="EN-US" style="font-size: 10pt; font-family: 'Times New Roman', serif; color: navy;">Yuri Veselov</span></b><span lang="EN-US" style="font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt 8.5pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span lang="EN-US" style="font-size: 10pt; font-family: 'Courier New'; color: navy;">INNL, Nizhny Novgorod, Russia</span><span lang="EN-US" style="font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt 8.5pt; font-size: 11pt; font-family: Calibri, sans-serif;"><span style="font-size: 10pt; font-family: 'Wingdings 2'; color: purple;">'</span><i><span style="font-size: 10pt; font-family: 'Courier New'; color: navy;">+7(831)</span></i><b><span style="font-size: 10pt; font-family: 'Courier New CYR'; color: navy;">296</span></b><b><span style="font-size: 10pt; font-family: 'Courier New'; color: navy;">-9</span></b><b><span style="font-size: 10pt; font-family: 'Courier New CYR'; color: navy;">4</span></b><b><span style="font-size: 10pt; font-family: 'Courier New'; color: navy;">-</span></b><b><span style="font-size: 10pt; font-family: 'Courier New CYR'; color: navy;">44</span></b><b><span style="font-size: 10pt; font-family: 'Courier New'; color: navy;">;</span></b><i><span style="font-size: 10pt; font-family: 'Courier New'; color: navy;">ext.</span></i><b><span style="font-size: 10pt; font-family: 'Courier New'; color: navy;">2307</span></b><span style="font-size: 12pt; font-family: 'Times New Roman', serif;"><o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt 8.5pt; font-size: 11pt; font-family: Calibri, sans-serif;"><b><span style="font-size: 10pt; font-family: Wingdings; color: purple;">*</span></b><span style="font-size: 10pt; font-family: 'Courier New'; color: navy;"><a href="mailto:Yuri.Veselov@Intel.com" style="color: purple; text-decoration: underline;">Yuri.Veselov@Intel.com</a><o:p></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"><o:p> </o:p></div></div><p><br>--------------------------------------------------------------------<br>Closed Joint Stock Company Intel A/O<br>Registered legal address: Krylatsky Hills Business Park,<span class="Apple-converted-space"> </span><br>17 Krylatskaya Str., Bldg 4, Moscow 121614,<span class="Apple-converted-space"> </span><br>Russian Federation</p><p>This e-mail and any attachments may contain confidential material for<br>the sole use of the intended recipient(s). Any review or distribution<br>by others is strictly prohibited. If you are not the intended<br>recipient, please contact the sender and delete all copies.</p><span><interpreter_patch.diff></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline;">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" style="color: purple; text-decoration: underline;">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>