[PATCH] get rid of annoying windows warning C4146 in APInt.h ( no semantics change )

Duncan Sands baldrick at free.fr
Wed Feb 27 10:27:57 PST 2013


Hi Peng,

On 27/02/13 04:55, Peng Cheng wrote:
> -1ULL has created windows warning C4146 when including this header.
>
> Changing -1ULL to UINT64_MAX fixes the warning, while without changing
> semantics.  It also could be cheaper because there is no need for truncation to
> 64bit if ULL is more than 64bit long in some machine.
>
> See fix in patch attached.

LGTM.

Ciao, Duncan.




More information about the llvm-commits mailing list