[PATCH] get rid of annoying windows warning C4146 in APInt.h ( no semantics change )

Aaron Ballman aaron at aaronballman.com
Wed Feb 27 10:44:12 PST 2013


Patch committed in r176197, thank you for the patch!

~Aaron

On Wed, Feb 27, 2013 at 1:27 PM, Duncan Sands <baldrick at free.fr> wrote:
> Hi Peng,
>
>
> On 27/02/13 04:55, Peng Cheng wrote:
>>
>> -1ULL has created windows warning C4146 when including this header.
>>
>> Changing -1ULL to UINT64_MAX fixes the warning, while without changing
>> semantics.  It also could be cheaper because there is no need for
>> truncation to
>> 64bit if ULL is more than 64bit long in some machine.
>>
>> See fix in patch attached.
>
>
> LGTM.
>
> Ciao, Duncan.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list