Review request: generate DWARF pubnames under a compiler option

[Eric Christopher]

On Tue, Feb 12, 2013 at 9:13 AM, Eric Christopher <echristo at gmail.com>wrote:

>
>
> On Tue, Feb 12, 2013 at 9:06 AM, Krzysztof Parzyszek <
> kparzysz at codeaurora.org> wrote:
>
>> On 2/11/2013 4:20 PM, Eric Christopher wrote:
>>
>>>
>>> [...] Also, I'd hope that whatever way you're iterating over the list is
>>>
>>> stable. I didn't think to check that, so if it isn't please make sure it
>>> is.
>>>
>>
>> The StringMap iterator will give the same sequence for each map that has
>> been filled with the same contents and the individual insertions were done
>> in the same order.  Unless the code that inserts the names into the map
>> changes, the results should be the same.
>>
>> On a somewhat different note---is there a way to test the change to
>> llvm-dwarfdump?  I already committed it without a test, and testing it
>> would require something like a pre-existing object file to parse.  I saw
>> that there were other testcases that had object files associated with
>> them---is this the usual strategy?
>>
>>
> Yep.
>
>
To elaborate this object file should match the end-to-end testcase that you
add for the emission that you also test.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130212/0b6c810f/attachment.html>