Review request: generate DWARF pubnames under a compiler option

Eric Christopher echristo at gmail.com
Tue Feb 12 09:13:36 PST 2013


On Tue, Feb 12, 2013 at 9:06 AM, Krzysztof Parzyszek <
kparzysz at codeaurora.org> wrote:

> On 2/11/2013 4:20 PM, Eric Christopher wrote:
>
>>
>> [...] Also, I'd hope that whatever way you're iterating over the list is
>>
>> stable. I didn't think to check that, so if it isn't please make sure it
>> is.
>>
>
> The StringMap iterator will give the same sequence for each map that has
> been filled with the same contents and the individual insertions were done
> in the same order.  Unless the code that inserts the names into the map
> changes, the results should be the same.
>
> On a somewhat different note---is there a way to test the change to
> llvm-dwarfdump?  I already committed it without a test, and testing it
> would require something like a pre-existing object file to parse.  I saw
> that there were other testcases that had object files associated with
> them---is this the usual strategy?
>
>
Yep.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130212/044f5b86/attachment.html>


More information about the llvm-commits mailing list