[PATCH 3/3] ARM cost model: Cost for scalar integer casts and floating point conversions

Arnold Schwaighofer aschwaighofer at apple.com
Fri Feb 1 11:05:17 PST 2013


I created four tables:

- NEONVectorConversionTbl for vector
- NEONFloatConversionTbl for scalar floating point
- NEONIntegerConversionTbl for scalar int to floating point
- ARMIntegerConversionTbl for scalar int 

Thanks,
Arnold

On Feb 1, 2013, at 10:52 AM, Arnold Schwaighofer <aschwaighofer at apple.com> wrote:
> On Feb 1, 2013, at 10:03 AM, Renato Golin <renato.golin at linaro.org> wrote:
>> 
>> However, the table is called NEONConversionTbl and there's a test below (if ST->hasNEON), so it'd be better if the non-vector instructions could be added to a separate table.
>> 
>> Possibly adding an Ty->isVector() && ST->hasNEON() or some combination that allows for both vectorized and scalar codes to execute correctly on all possible combinations, but doesn't iterate through the wrong table when the type is obviously not there.
> 
> Yes, you are absolutely right. Will fix this. I was so focused on the table that I forgot about the surrounding code. Also better for performance (makes for shorter linear searches).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ARM-cost-model-Cost-for-scalar-integer-casts-and-flo.patch
Type: application/octet-stream
Size: 12234 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130201/c3f0ae66/attachment.obj>


More information about the llvm-commits mailing list