[PATCH 3/3] ARM cost model: Cost for scalar integer casts and floating point conversions

[Arnold Schwaighofer]

On Feb 1, 2013, at 10:03 AM, Renato Golin <renato.golin at linaro.org> wrote:

> Thanks for adding these!
> 
> However, the table is called NEONConversionTbl and there's a test below (if ST->hasNEON), so it'd be better if the non-vector instructions could be added to a separate table.
> 
> Possibly adding an Ty->isVector() && ST->hasNEON() or some combination that allows for both vectorized and scalar codes to execute correctly on all possible combinations, but doesn't iterate through the wrong table when the type is obviously not there.

Yes, you are absolutely right. Will fix this. I was so focused on the table that I forgot about the surrounding code. Also better for performance (makes for shorter linear searches).

Thanks,
Arnold