[llvm-commits] [llvm] r171158 - in /llvm/trunk/include/llvm: ADT/IntervalMap.h CodeGen/SlotIndexes.h

[Jakob Stoklund Olesen]

On Jan 3, 2013, at 4:20 PM, Chandler Carruth <chandlerc at gmail.com> wrote:

> On Sat, Dec 29, 2012 at 1:13 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
> 
> On Dec 27, 2012, at 3:29 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
> 
> > Author: chandlerc
> > Date: Thu Dec 27 05:29:17 2012
> > New Revision: 171158
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=171158&view=rev
> > Log:
> > Provide a common half-open interval map info implementation, and just
> > re-use that for SlotIndexes. This way other users who want half-open
> > semantics can share the implementation.
> 
> Hi Chandler,
> 
> In retrospect, I think it was a premature abstraction to support closed intervals at all. It wasn't quite clear at the time if SlotIndexes would work better with closed or half-open intervals. That has been settled now, they definitely want half-open intervals.
> 
> Do we want to retain any support for closed intervals? I would assume not...

I don't see a need for it.

Please do preserve the separate traits functions for '<' and '=='. For SlotIndexes, a == b is significantly faster than !(a < b || b < a).

> I'll make it so whichever it is.

Thanks,
/jakob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130103/ce910e07/attachment.html>