<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 3, 2013, at 4:20 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com">chandlerc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_default" style="">On Sat, Dec 29, 2012 at 1:13 PM, Jakob Stoklund Olesen <span dir="ltr"><<a href="mailto:stoklund@2pi.dk" target="_blank" class="cremed">stoklund@2pi.dk</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
On Dec 27, 2012, at 3:29 AM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="cremed">chandlerc@gmail.com</a>> wrote:<br>
<br>
> Author: chandlerc<br>
> Date: Thu Dec 27 05:29:17 2012<br>
> New Revision: 171158<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=171158&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=171158&view=rev</a><br>
> Log:<br>
> Provide a common half-open interval map info implementation, and just<br>
> re-use that for SlotIndexes. This way other users who want half-open<br>
> semantics can share the implementation.<br>
<br>
</div>Hi Chandler,<br>
<br>
In retrospect, I think it was a premature abstraction to support closed intervals at all. It wasn't quite clear at the time if SlotIndexes would work better with closed or half-open intervals. That has been settled now, they definitely want half-open intervals.<br>
</blockquote><div><br></div><div style="">Do we want to retain any support for closed intervals? I would assume not...</div></div></div></div></blockquote><div><br></div><div>I don't see a need for it.</div><div><br></div><div>Please do preserve the separate traits functions for '<' and '=='. For SlotIndexes, a == b is significantly faster than !(a < b || b < a).</div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style="">I'll make it so whichever it is.</div></div></div></div>
</blockquote></div><br><div>Thanks,</div><div>/jakob</div><div><br></div></body></html>