[llvm-commits] [PATCH] PR14471: Debug info for static data members (LLVM part)

[Robinson, Paul]

Now that I look at the diff more closely, I see something went wrong and a chunk of it is indeed missing.

I doubt I can fix it until llvm.org comes back up, I think I screwed up the merge with Chandler's renaming.

--paulr



________________________________
From: Eric Christopher [echristo at gmail.com]
Sent: Thursday, January 03, 2013 11:17 AM
To: Robinson, Paul
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] PR14471: Debug info for static data members (LLVM part)



This is in enum llvm_dwarf_constants, not enum dwarf_constants.
It's one of several mock tags defined for the metadata interface;
they are not defined by DWARF.  (If the number of real DWARF tags
doubles, we'll have to renumber these to get out of the way.)


Yeah, we're looking at getting rid of those, I'm not sure it's needed ... (more at the end)

> And you don't disassemble to it either.
Not sure what you mean here.

You didn't add code to dump the tag. See DW_TAG_arg_variable as an example.


> Also you don't use isStaticData()...
>
> Perhaps there's some part of the patch I'm missing?

See the Clang part of the patch, which does use isStaticDataMember().

Aah. Why not just check the decl to see if it's a static data member before doing the lookup?

-eric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130103/49226efb/attachment.html>