<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle">P {
MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
</style>
</head>
<body fPStyle="1" ocsi="0">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">
<p>Now that I look at the diff more closely, I see something went wrong and a chunk of it is indeed missing.</p>
<p>I doubt I can fix it until llvm.org comes back up, I think I screwed up the merge with Chandler's renaming.</p>
<p>--paulr</p>
<p> </p>
<div style="FONT-FAMILY: Times New Roman; COLOR: #000000; FONT-SIZE: 16px">
<hr tabindex="-1">
<div style="DIRECTION: ltr" id="divRpF266685"><font color="#000000" size="2" face="Tahoma"><b>From:</b> Eric Christopher [echristo@gmail.com]<br>
<b>Sent:</b> Thursday, January 03, 2013 11:17 AM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [llvm-commits] [PATCH] PR14471: Debug info for static data members (LLVM part)<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr"><br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">
<div>
<div style="FONT-FAMILY: Tahoma; DIRECTION: ltr; FONT-SIZE: 10pt">
<div style="FONT-FAMILY: Times New Roman; FONT-SIZE: 16px">
<div>
<div dir="ltr">
<div><br>
</div>
<div>This is in enum llvm_dwarf_constants, not enum dwarf_constants.</div>
<div>It's one of several mock tags defined for the metadata interface;</div>
<div>they are not defined by DWARF. (If the number of real DWARF tags</div>
<div>doubles, we'll have to renumber these to get out of the way.)</div>
<div>
<div> </div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>Yeah, we're looking at getting rid of those, I'm not sure it's needed ... (more at the end)</div>
<div> </div>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">
<div>
<div style="FONT-FAMILY: Tahoma; DIRECTION: ltr; FONT-SIZE: 10pt">
<div style="FONT-FAMILY: Times New Roman; FONT-SIZE: 16px">
<div>
<div dir="ltr">
<div>
<div>> And you don't disassemble to it either.</div>
</div>
<div>Not sure what you mean here.</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>You didn't add code to dump the tag. See DW_TAG_arg_variable as an example.</div>
<div> </div>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">
<div>
<div style="FONT-FAMILY: Tahoma; DIRECTION: ltr; FONT-SIZE: 10pt">
<div style="FONT-FAMILY: Times New Roman; FONT-SIZE: 16px">
<div>
<div dir="ltr">
<div>
<div><br>
> Also you don't use isStaticData()...</div>
<div>><br>
</div>
<div>> Perhaps there's some part of the patch I'm missing?</div>
<div> </div>
</div>
<div>See the Clang part of the patch, which does use isStaticDataMember().</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>Aah. Why not just check the decl to see if it's a static data member before doing the lookup?</div>
<div><br>
</div>
<div>-eric</div>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</body>
</html>