[llvm-commits] [PATCH] PR14471: Debug info for static data members (LLVM part)

Eric Christopher echristo at gmail.com
Wed Jan 2 19:03:42 PST 2013

Few comments:

+  DW_TAG_CXX_static_member = 0x104,     // Tag for C++ static data member.

there is no such tag that I've seen? And you don't disassemble to it either.

Also you don't use isStaticData()...

Perhaps there's some part of the patch I'm missing?


On Wed, Jan 2, 2013 at 1:38 PM, Eric Christopher <echristo at gmail.com> wrote:

> Sitting in my to review, but thanks for the ping I'll get to them tonight.
> -eric
> On Wed, Jan 2, 2013 at 1:32 PM, Robinson, Paul <Paul.Robinson at am.sony.com>wrote:
>> Ping with updated patch & directly cc Eric.
>> --paulr
>> ________________________________________
>> From: llvm-commits-bounces at cs.uiuc.edu [llvm-commits-bounces at cs.uiuc.edu]
>> on behalf of Robinson, Paul [Paul.Robinson at am.sony.com]
>> Sent: Tuesday, December 18, 2012 12:10 PM
>> To: llvm-commits at cs.uiuc.edu
>> Subject: [llvm-commits] [PATCH] PR14471: Debug info for static data
>> members     (LLVM part)
>> Define metadata interfaces for describing a static data member of a
>> class.  Emit static data member declarations and definitions to DWARF
>> correctly.  (Would not be hard to extend the new interface to handle
>> all data members, rather than using the DIDerivedType hack.)
>> LLVM part of the fix for PR14471.
>> --paulr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130102/21d139b6/attachment.html>

More information about the llvm-commits mailing list