[llvm-commits] [PATCH] PowerPC: Expand load extend vector operations

Adhemerval Zanella azanella at linux.vnet.ibm.com
Mon Nov 5 09:17:58 PST 2012


On 11/05/2012 11:37 AM, Hal Finkel wrote:
> One quick comment: the FileCheck does a prefix match on the check string, so it is not really necessary to include 'match everything' trailing regex patterns. For example:
> +; CHECK: lbz {{[0-9]+}}, {{[-]*[0-9]+}}({{[0-9]+}})
> could be just
> +; CHECK: lbz
>
> On one hand, the extra patterns serve as an extra check on the asm printer. On the other hand, I think that they might make the tests harder to read. I'll leave it up to you (or, if anyone else has an opinion, please share).
>
> Otherwise, LGTM.
>
> Thanks again,
> Hal

Indeed it seems superfluous, I changed to just 'lbz/std'. Committed as revision 167386.




More information about the llvm-commits mailing list