[llvm-commits] [llvm] r165140 - /llvm/trunk/unittests/ADT/StringRefTest.cpp

[Benjamin Kramer]

Author: d0k
Date: Wed Oct  3 13:54:36 2012
New Revision: 165140

URL: http://llvm.org/viewvc/llvm-project?rev=165140&view=rev
Log:
Don't call getAsUnsignedInteger directly, it fails to compile if uint64_t is not "unsigned long long".

while there add more test cases.

Modified:
    llvm/trunk/unittests/ADT/StringRefTest.cpp

Modified: llvm/trunk/unittests/ADT/StringRefTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/StringRefTest.cpp?rev=165140&r1=165139&r2=165140&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/StringRefTest.cpp (original)
+++ llvm/trunk/unittests/ADT/StringRefTest.cpp Wed Oct  3 13:54:36 2012
@@ -462,13 +462,17 @@
   , "123456789012345678901" // value way too large
   , "4t23v"                 // illegal decimal characters
   , "0x123W56"              // illegal hex characters
+  , "0b2"                   // illegal bin characters
+  , "08"                    // illegal oct characters
+  , "0o8"                   // illegal oct characters
+  , "-123"                  // negative unsigned value
 };
 
 
 TEST(StringRefTest, getAsUnsignedIntegerBadStrings) {
   uint64_t U64;
   for (size_t i = 0; i < array_lengthof(BadStrings); ++i) {
-    bool IsBadNumber = getAsUnsignedInteger(BadStrings[i], 0, U64);
+    bool IsBadNumber = StringRef(BadStrings[i]).getAsInteger(0, U64);
     ASSERT_TRUE(IsBadNumber);
   }
 }