[llvm-commits] [llvm] r165136 - /llvm/trunk/unittests/ADT/StringRefTest.cpp

Nick Kledzik kledzik at apple.com
Wed Oct 3 11:15:27 PDT 2012


Author: kledzik
Date: Wed Oct  3 13:15:27 2012
New Revision: 165136

URL: http://llvm.org/viewvc/llvm-project?rev=165136&view=rev
Log:
Add getAsUnsignedInteger test case that checks that known bad values are rejected

Modified:
    llvm/trunk/unittests/ADT/StringRefTest.cpp

Modified: llvm/trunk/unittests/ADT/StringRefTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/StringRefTest.cpp?rev=165136&r1=165135&r2=165136&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/StringRefTest.cpp (original)
+++ llvm/trunk/unittests/ADT/StringRefTest.cpp Wed Oct  3 13:15:27 2012
@@ -456,4 +456,23 @@
   }
 }
 
+
+static const char* BadStrings[] = {
+    "18446744073709551617"  // value just over max
+  , "123456789012345678901" // value way too large
+  , "4t23v"                 // illegal decimal characters
+  , "0x123W56"              // illegal hex characters
+};
+
+
+TEST(StringRefTest, getAsUnsignedIntegerBadStrings) {
+  uint64_t U64;
+  for (size_t i = 0; i < array_lengthof(BadStrings); ++i) {
+    bool IsBadNumber = getAsUnsignedInteger(BadStrings[i], 0, U64);
+    ASSERT_TRUE(IsBadNumber);
+  }
+}
+
+
+
 } // end anonymous namespace





More information about the llvm-commits mailing list