[llvm-commits] Mips assembler implementation patch

[Medic, Vladimir]

Hi Carl,
thank you for your remarks and the patch. I have removed two lines that caused this warning and the new patch is attached to this email.
Did anybody else had a chance to look at this?

Thanks

Vladimir
________________________________
From: Carl Norum [carl at lytro.com]
Sent: Thursday, August 30, 2012 7:07 PM
To: Medic, Vladimir
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] Mips assembler implementation patch


Works great here - I needed to add "mfc0" for my project, so I've attached that patch-to-your-patch here.    This patch is my first attempt at doing anything in a tablegen file, so a good look by someone more experienced will be much appreciated!

I also get these two warnings when building with your patch:

lib/Target/Mips/AsmParser/MipsAsmParser.cpp:407:13: warning:
      unused variable 'MnemLower' [-Wunused-variable]
  StringRef MnemLower = Mnemonic.lower();
            ^
lib/Target/Mips/AsmParser/MipsAsmParser.cpp:597:9: warning:
      unused variable 'E' [-Wunused-variable]
  SMLoc E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer()-1);
        ^
2 warnings generated.

I didn't address those with the patch in my attachment, though.

-- Carl


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120831/00d677b4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MipsAssemblerImplemenation.patch
Type: application/octet-stream
Size: 49471 bytes
Desc: MipsAssemblerImplemenation.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120831/00d677b4/attachment.obj>