<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1" style="word-wrap:break-word">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Hi Carl,<br>
thank you for your remarks and the patch. I have removed two lines that caused this warning and the new patch is attached to this email.<br>
Did anybody else had a chance to look at this?<br>
<br>
Thanks<br>
<br>
Vladimir<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF748014"><font color="#000000" face="Tahoma" size="2"><b>From:</b> Carl Norum [carl@lytro.com]<br>
<b>Sent:</b> Thursday, August 30, 2012 7:07 PM<br>
<b>To:</b> Medic, Vladimir<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [llvm-commits] Mips assembler implementation patch<br>
</font><br>
</div>
<div></div>
<div>
<div><br>
</div>
<div>Works great here - I needed to add "mfc0" for my project, so I've attached that patch-to-your-patch here. This patch is my first attempt at doing anything in a tablegen file, so a good look by someone more experienced will be much appreciated!</div>
<div><br>
</div>
<div>I also get these two warnings when building with your patch:</div>
<div><br>
</div>
<div>
<div></div>
</div>
<blockquote type="cite">
<div>
<div>lib/Target/Mips/AsmParser/MipsAsmParser.cpp:407:13: warning: </div>
<div> unused variable 'MnemLower' [-Wunused-variable]</div>
<div> StringRef MnemLower = Mnemonic.lower();</div>
<div> ^</div>
<div>lib/Target/Mips/AsmParser/MipsAsmParser.cpp:597:9: warning: </div>
<div> unused variable 'E' [-Wunused-variable]</div>
<div> SMLoc E = SMLoc::getFromPointer(Parser.getTok().getLoc().getPointer()-1);</div>
<div> ^</div>
<div>2 warnings generated.</div>
</div>
</blockquote>
<div><br>
</div>
<div>I didn't address those with the patch in my attachment, though.</div>
<div><br>
</div>
<div>-- Carl</div>
<div><br>
</div>
<div><br>
</div>
</div>
</div>
</div>
</body>
</html>