[llvm-commits] [compiler-rt] r162981 - in /compiler-rt/trunk/lib: asan/Makefile.old asan/README.txt tsan/Makefile.old

[Alexey Samsonov]

Author: samsonov
Date: Fri Aug 31 03:10:28 2012
New Revision: 162981

URL: http://llvm.org/viewvc/llvm-project?rev=162981&view=rev
Log:
[Sanitizer] Remove lint checkers from our old makefiles in favor of buildbot

Modified:
    compiler-rt/trunk/lib/asan/Makefile.old
    compiler-rt/trunk/lib/asan/README.txt
    compiler-rt/trunk/lib/tsan/Makefile.old

Modified: compiler-rt/trunk/lib/asan/Makefile.old
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/Makefile.old?rev=162981&r1=162980&r2=162981&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/Makefile.old (original)
+++ compiler-rt/trunk/lib/asan/Makefile.old Fri Aug 31 03:10:28 2012
@@ -196,7 +196,7 @@
 
 all: b64 b32
 
-test: t64 t32 output_tests lint
+test: t64 t32 output_tests
 	@echo "ALL TESTS PASSED"
 
 output_tests: b32 b64
@@ -320,27 +320,11 @@
 	$(MAKE) -f ../make/Makefile CXXFLAGS="$(PIE) $(CFLAGS) -g -w" \
 	  CXX="$(CLANG_CXX)"
 
-RTL_LINT_FILTER=-readability/casting,-readability/check,-build/include,-build/header_guard,-build/class,-legal/copyright,-build/namespaces
-# TODO(kcc): remove these filters one by one
-TEST_LINT_FILTER=-readability/casting,-build/include,-legal/copyright,-whitespace/newline,-runtime/sizeof,-runtime/int,-runtime/printf
-
-LLVM_LINT_FILTER=-,+whitespace
-
-ADDRESS_SANITIZER_CPP=../../../../lib/Transforms/Instrumentation/AddressSanitizer.cpp
-
-lint:
-	third_party/cpplint/cpplint.py --filter=$(LLVM_LINT_FILTER) $(ADDRESS_SANITIZER_CPP)
-	third_party/cpplint/cpplint.py --filter=$(RTL_LINT_FILTER) asan_*.cc asan_*.h
-	third_party/cpplint/cpplint.py --filter=$(RTL_LINT_FILTER) $(INTERCEPTION)/interception*.h $(INTERCEPTION)/interception*.cc
-	third_party/cpplint/cpplint.py --filter=$(RTL_LINT_FILTER) $(COMMON)/sanitizer_*.h $(COMMON)/sanitizer_*.cc
-	third_party/cpplint/cpplint.py --filter=$(TEST_LINT_FILTER) tests/*.cc output_tests/*.cc
-
 get_third_party:
 	rm -rf third_party
 	mkdir third_party
 	(cd third_party && \
-	svn co -r375        http://googletest.googlecode.com/svn/trunk googletest && \
-	svn co -r69 http://google-styleguide.googlecode.com/svn/trunk/cpplint cpplint \
+	svn co -r375        http://googletest.googlecode.com/svn/trunk googletest \
 	)
 
 clean:

Modified: compiler-rt/trunk/lib/asan/README.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/README.txt?rev=162981&r1=162980&r2=162981&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/README.txt (original)
+++ compiler-rt/trunk/lib/asan/README.txt Fri Aug 31 03:10:28 2012
@@ -15,7 +15,7 @@
 Temporary build instructions (verified on linux):
 
 cd lib/asan
-make -f Makefile.old get_third_party  # gets googletest and cpplint
+make -f Makefile.old get_third_party  # gets googletest
 make -f Makefile.old test -j 8 CLANG_BUILD=/path/to/Release+Asserts
 # Optional:
 # make -f Makefile.old install # installs clang and rt to lib/asan_clang_linux

Modified: compiler-rt/trunk/lib/tsan/Makefile.old
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/Makefile.old?rev=162981&r1=162980&r2=162981&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/Makefile.old (original)
+++ compiler-rt/trunk/lib/tsan/Makefile.old Fri Aug 31 03:10:28 2012
@@ -34,7 +34,6 @@
 	@ echo "The most useful targets are:"
 	@ echo "  make install_deps  # Install third-party dependencies required for building"
 	@ echo "  make presubmit     # Run it every time before committing"
-	@ echo "  make lint          # Run the style checker"
 	@ echo
 	@ echo "For more info, see http://code.google.com/p/data-race-test/wiki/ThreadSanitizer2"
 
@@ -57,7 +56,6 @@
 	./output_tests/test_output.sh
 
 presubmit:
-	$(MAKE) -f Makefile.old lint -j 4
 	# Debug build with clang.
 	$(MAKE) -f Makefile.old clean
 	$(MAKE) -f Makefile.old run DEBUG=1 -j 16 CC=clang CXX=clang++
@@ -73,28 +71,13 @@
 	./check_analyze.sh
 	@ echo PRESUBMIT PASSED
 
-RTL_LINT_FITLER=-legal/copyright,-build/include,-readability/casting,-build/header_guard,-build/namespaces
-
-lint: lint_tsan lint_tests
-lint_tsan:
-	third_party/cpplint/cpplint.py --filter=$(RTL_LINT_FITLER) rtl/*.{cc,h} \
-        ../sanitizer_common/*.{cc,h}
-lint_tests:
-	third_party/cpplint/cpplint.py --filter=$(RTL_LINT_FITLER) \
-        rtl_tests/*.{cc,h} unit_tests/*.cc ../sanitizer_common/tests/*.cc
-
 install_deps:
 	rm -rf third_party
 	mkdir third_party
 	(cd third_party && \
-	svn co -r613 http://googletest.googlecode.com/svn/trunk googletest && \
-	svn co -r82 http://google-styleguide.googlecode.com/svn/trunk/cpplint cpplint \
+	svn co -r613 http://googletest.googlecode.com/svn/trunk googletest \
         )
 
-# Remove verbose printf from lint. Not strictly necessary.
-hack_cpplint:
-	sed -i "s/  sys.stderr.write('Done processing.*//g" third_party/cpplint/cpplint.py
-
 $(GTEST_LIB):
 	mkdir -p $(GTEST_BUILD_DIR) && \
 	cd $(GTEST_BUILD_DIR) && \