[llvm-commits] [PATCH RFC] change comma delimeter in llvm/test/Makefile

[Will Schmidt]

Hi all, 

Both the ppc64 buildbot and myself are hitting 'sed' errors in the
creation of lit.site.cfg out of test/Makefile.

http://lab.llvm.org:8011/builders/llvm-ppc64-linux1/builds/105/steps/test-llvm/logs/stdio 

make[1]: Entering directory `/home/willschm/head/llvm/test'
Making LLVM 'lit.site.cfg' file...
sed: file lit.tmp line 1: unknown option to `s'
make[1]: *** [lit.site.cfg] Error 1
...

Relevant portion of my lit.tmp looks like so:
s, at OCAMLOPT@,/bin/ocamlopt -cc \\"g++ -Wall -D_FILE_OFFSET_BITS=64
-D_REENTRANT -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64\\"
-I /home/willschm/head/llvm/Release+Asserts/lib/ocaml,g

The previous iteration of this problem was due to my CFLAGS fields
containing equal signs.  Turns out my CFLAGS also contain the occasional
comma. 
i.e.   " -Wp,-D_FORTIFY_SOURCE=2 "

Using hash '#' in place of comma ',' and/or the equals '=' fixes this
for me.  Does this break anyone else? 

Please Commit if OK.   

Thanks, 
-Will

-------------- next part --------------
A non-text attachment was scrubbed...
Name: update_test_makefile_with_hash.aug29.1.diff
Type: text/x-patch
Size: 764 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120829/2fe9d541/attachment.bin>