[llvm-commits] [Sanitizer] PATCH: Enable CMake build of llvm-symbolizer used by sanitizer tools

Chandler Carruth chandlerc at google.com
Mon Aug 27 00:59:12 PDT 2012


A couple of high-level points:

- I think I would prefer this to not live under the 'lib' tree in
compiler-rt. I think the most consist name compared to other tools in the
tree would be "utils/llvm-symbolizer", but I'm interested to hear other
thoughts here. In the LLVM project itself, the "utils/..." tree is built
before libraries, and can be used by them, while the "tools/..." tree is
built after libraries and can use them. It seems like if this lives in
compiler-rt, it should then be under a 'utils' tree, and if it ever moves
into LLVM itself, it would live under 'tools'.

- I think you can actually do more hackery here. ;] I think you can scrape
the compile flags and definitions out of the original library rule. You
should also scrape any hard dependencies that are in place for things like
generated source code. That probably means your macro needs to be something
more generic than just appending sources...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120827/a2d4ee6d/attachment.html>


More information about the llvm-commits mailing list