[llvm-commits] [llvm] r155012 - in /llvm/trunk: include/llvm/TableGen/Error.h lib/TableGen/Error.cpp

[Jakob Stoklund Olesen]

On Apr 18, 2012, at 1:15 PM, Chandler Carruth <chandlerc at google.com> wrote:

> On Wed, Apr 18, 2012 at 1:04 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
> 
> On Apr 18, 2012, at 12:58 PM, Chandler Carruth <chandlerc at google.com> wrote:
> 
>> On Wed, Apr 18, 2012 at 11:11 AM, Jim Grosbach <grosbach at apple.com> wrote:
>> Indeed. No reason it's not there that I can think of beyond, "nobody has added it yet."
>> 
>> We completely control both the implementation and all users of tablegen. Do we really need two levels here? If we turn on -Werror and forget about it, why not just make everything an error to start with?
> 
> There are out-of-tree users of TableGen. I don't think it is necessary to force them to write nice .td files.
> 
> Insert rant about people not fixing warnings…

I would want it to be enabled for all in-tree targets. I think it might even be a good idea to implement a -w option instead of -Werror.

People who don't fix warnings get their patches reverted if they don't react soon… ;-)

/jakob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120418/42d2188f/attachment.html>