<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 18, 2012, at 1:15 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Wed, Apr 18, 2012 at 1:04 PM, Jakob Stoklund Olesen <span dir="ltr"><<a href="mailto:stoklund@2pi.dk">stoklund@2pi.dk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<div style="word-wrap:break-word"><div><div class="h5"><br><div><div>On Apr 18, 2012, at 12:58 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:</div><br><blockquote type="cite">
<div class="gmail_quote">On Wed, Apr 18, 2012 at 11:11 AM, Jim Grosbach <span dir="ltr"><<a href="mailto:grosbach@apple.com" target="_blank">grosbach@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<div>Indeed. No reason it's not there that I can think of beyond, "nobody has added it yet."<div><div></div></div></div></blockquote></div><br><div>
We completely control both the implementation and all users of tablegen. Do we really need two levels here? If we turn on -Werror and forget about it, why not just make everything an error to start with?</div>
</blockquote></div><br></div></div><div>There are out-of-tree users of TableGen. I don't think it is necessary to force them to write nice .td files.</div></div></blockquote><div><br></div><div>Insert rant about people not fixing warnings…</div></div></blockquote><div><br></div><div>I would want it to be enabled for all in-tree targets. I think it might even be a good idea to implement a -w option instead of -Werror.</div><div><br></div><div>People who don't fix warnings get their patches reverted if they don't react soon… ;-)</div><div><br></div><div>/jakob</div><div><br></div></div></body></html>