[llvm-commits] [PATCH] LIT cleanup phase #3 - remove usage of bash

Chandler Carruth chandlerc at google.com
Mon Mar 26 00:38:34 PDT 2012


On Sun, Mar 25, 2012 at 5:40 AM, Bendersky, Eli <eli.bendersky at intel.com>wrote:

> Following PR 5240 (http://llvm.org/bugs/show_bug.cgi?id=5240), this patch
> removes LIT’s usage of bash where it can find it. Bash was originally used
> for performance reasons, but currently runs show no difference with and
> without bash
>

We still see performance improvements using bash. This may be an artifact
of an old, slow version of Python, but unless there is some pressing
refactoring of lit that removing the bash runner will unblock, can we just
leave it in? I'm not seeing this as a big source of technical debt, and
we're stuck with a lot of sub-optimal python implementations out in the
wild...

Also, I suspect we could make the bash variant significantly faster by
using bash more cleverly. Given the amount of time I spend waiting for lit
to finish, I'd much rather see work to make it run faster by using tools
better suited to process setup and teardown than python...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120326/f769b636/attachment.html>


More information about the llvm-commits mailing list