[llvm-commits] [llvm] r152105 - /llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp

[Jakob Stoklund Olesen]

On Mar 6, 2012, at 8:45 AM, Craig Topper <craig.topper at gmail.com> wrote:

> On Tue, Mar 6, 2012 at 8:32 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
> 
> On Mar 6, 2012, at 8:23 AM, Craig Topper wrote:
> 
> > It might not work with 64k registers. I didn't make the change to use one long string literal. I just exploited the C++ restriction that a string literal cant contain more 64K characters. I'll add asserts since that restriction might only be a warning.
> 
> That's just a minimum limit, clang and gcc have much larger limits. I expect so does most other modern compilers.

> I know its the minimum limit, but clang in default build configuration and Werror will fail if the string literal is larger than 64K doesn't that sort make the code base after obey the minimum limit?

Well, that means you have found a potential portability problem. You shouldn't make it worse by propagating the assumptions, try to fix it instead.

As I told you yesterday, people are writing targets with many registers. This patch would probably have broken those targets.

Please do not change the limits of the target descriptions without discussing it on the mailing list first.

/jakob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120306/f858058b/attachment.html>