[llvm-commits] [llvm] r152105 - /llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp

[Craig Topper]

On Tue, Mar 6, 2012 at 8:32 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:

>
> On Mar 6, 2012, at 8:23 AM, Craig Topper wrote:
>
> > It might not work with 64k registers. I didn't make the change to use
> one long string literal. I just exploited the C++ restriction that a string
> literal cant contain more 64K characters. I'll add asserts since that
> restriction might only be a warning.
>
> That's just a minimum limit, clang and gcc have much larger limits. I
> expect so does most other modern compilers.
>
> The C++ standard also says that unsigned is at least 16 bits. That doesn't
> mean you can replace it with uint16_t everywhere.
>
> /jakob
>
>
I know its the minimum limit, but clang in default build configuration and
Werror will fail if the string literal is larger than 64K doesn't that sort
make the code base after obey the minimum limit?


-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120306/ed8437cb/attachment.html>