[llvm-commits] [ASan] Replace AsanProcMaps::GetObjectNameAndOffset with a simpler AsanProcMaps::DescribeAddress (issue 5643047)

[timurrrr at google.com]

After thinking for a while and studying the code better I've decided to
leave the AsanProcMaps as-is.
See
http://codereview.appspot.com/5647052/diff/4001/lib/asan/asan_internal.h
instead.


http://codereview.appspot.com/5643047/diff/1/lib/asan/asan_linux.cc
File lib/asan/asan_linux.cc (right):

http://codereview.appspot.com/5643047/diff/1/lib/asan/asan_linux.cc#newcode265
lib/asan/asan_linux.cc:265: if
(dl_iterate_phdr(dl_iterate_phdr_callback, &data)) {
I meant Mac and Android.

On 2012/02/08 10:12:40, glider wrote:
> On 2012/02/07 17:41:15, timurrrr_at_google_com wrote:
> > Alternative suggestion:
> > I can extract this code to IterateForObjectNameAndOffset
> > and move the common AsanProcMaps::DescribeAddress code to
asan_posix.cc
> > (we have the same symbolization capabilities on Linux and Mac,
right?)
> >
> > WDYT?

> We do not have dl_iterate_phdr on Mac.

http://codereview.appspot.com/5643047/