[llvm-commits] [compiler-rt] r147796 - in /compiler-rt/trunk/lib/asan: asan_interceptors.cc asan_stack.cc

[Evgeniy Stepanov]

We are not removing _all_ system headers, are we? sigaction() comes from
pthread.h on Android.

On Tue, Jan 10, 2012 at 8:46 PM, Kostya Serebryany <kcc at google.com> wrote:

>
>
> On Tue, Jan 10, 2012 at 9:44 AM, Alexander Potapenko <glider at google.com>wrote:
>
>> On Tue, Jan 10, 2012 at 9:20 PM, Kostya Serebryany <kcc at google.com>
>> wrote:
>> > I've been trying to eliminate most system headers from asan rt (almost
>> > succeeded now).
>> > This simplifies the code and portability.
>> > The prototypes are different from the usual ones exactly because the
>> system
>> > headers are not included anymore.
>> > On Mac and Linux we have different ways to intercepts functions, so what
>> > initially worked on linux did not build on mac and I failed to properly
>> test
>> > it before commit.
>> >
>> > --kcc
>> The problem is that the headers are still included on Android, so
>> probably it's a good idea to keep the prototypes compatible.
>>
>
> Hm? Can't we remove the headers on Android as well?
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120110/3422ffc8/attachment.html>