[llvm-commits] [compiler-rt] r147796 - in /compiler-rt/trunk/lib/asan: asan_interceptors.cc asan_stack.cc

[Kostya Serebryany]

On Tue, Jan 10, 2012 at 9:50 AM, Evgeniy Stepanov <eugenis at google.com>wrote:

> We are not removing _all_ system headers, are we?


>From the interceptors.cc -- yes, I think we want to remove all headers
which define functions that we intercept.


> sigaction() comes from pthread.h on Android.


nice.
We don't include pthread.h directly, but I guess it comes from asan_lock.h.
I wanted to move this code from asan_lock.h to asan_linux/asan_mac anyway.
I'l do it.

--kcc


>
>
> On Tue, Jan 10, 2012 at 8:46 PM, Kostya Serebryany <kcc at google.com> wrote:
>
>>
>>
>> On Tue, Jan 10, 2012 at 9:44 AM, Alexander Potapenko <glider at google.com>wrote:
>>
>>> On Tue, Jan 10, 2012 at 9:20 PM, Kostya Serebryany <kcc at google.com>
>>> wrote:
>>> > I've been trying to eliminate most system headers from asan rt (almost
>>> > succeeded now).
>>> > This simplifies the code and portability.
>>> > The prototypes are different from the usual ones exactly because the
>>> system
>>> > headers are not included anymore.
>>> > On Mac and Linux we have different ways to intercepts functions, so
>>> what
>>> > initially worked on linux did not build on mac and I failed to
>>> properly test
>>> > it before commit.
>>> >
>>> > --kcc
>>> The problem is that the headers are still included on Android, so
>>> probably it's a good idea to keep the prototypes compatible.
>>>
>>
>> Hm? Can't we remove the headers on Android as well?
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120110/bb237b34/attachment.html>