[llvm-commits] Deterministic finite automaton based packetizer for VLIW architectures

[Jakob Stoklund Olesen]

On Nov 30, 2011, at 2:44 PM, Anshuman Dasgupta wrote:

> 
> Jakob,
> 
> I've attached a modified patch with the changes you suggested. A couple of comments: I will remove the emission of the second table when I split up the transition tables for each subtarget in Hexagon since those two tasks are related. Also, it was possible to change most of the STL containers (but not all) to LLVM equivalents. Let me know if it's okay to commit. I will post the CodeGenerator.html changes as a separate patch.
> 

+++ b/utils/TableGen/DFAPacketizerEmitter.h
+
+using namespace llvm;
+
+namespace {
+

These are both strictly verboten in headers.  Also see http://llvm.org/docs/CodingStandards.html#micro_anonns

Just move these classes into the .cpp file.

+++ b/utils/TableGen/DFAPacketizerEmitter.cpp
+#include <fstream>

?

+++ b/include/llvm/CodeGen/DFAPacketizer.h
+    int CurrentState;
+    const int (*DFAStateInputTable)[2];

Why int?

Also, please strip trailing whitespace from your patch. We have too much of that already.

/jakob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111130/15219566/attachment.html>