<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 30, 2011, at 2:44 PM, Anshuman Dasgupta wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div bgcolor="#FFFFFF" text="#000000">
<tt><br>
</tt><tt>Jakob,<br>
<br>
I've attached a modified patch with the changes you suggested. A
couple of comments: I will remove the emission of the second table
when I split up the transition tables for each subtarget in
Hexagon since those two tasks are related. Also, it was possible
to change most of the STL containers (but not all) to LLVM
equivalents. Let me know if it's okay to commit. I will post the
CodeGenerator.html changes as a separate patch.<br>
<br></tt></div></blockquote><div><br></div><div><div>+++ b/utils/TableGen/DFAPacketizerEmitter.h</div><div>+</div></div><div><div>+using namespace llvm;</div><div>+</div><div>+namespace {</div><div>+</div></div><div><br></div><div>These are both strictly verboten in headers. Also see <a href="http://llvm.org/docs/CodingStandards.html#micro_anonns">http://llvm.org/docs/CodingStandards.html#micro_anonns</a></div><div><br></div><div>Just move these classes into the .cpp file.</div><div><br></div><div><div>+++ b/utils/TableGen/DFAPacketizerEmitter.cpp</div><div><div>+#include <fstream></div></div><div><br></div><div>?</div><div><br></div><div><div>+++ b/include/llvm/CodeGen/DFAPacketizer.h</div></div><div><div>+ int CurrentState;</div></div><div><div>+ const int (*DFAStateInputTable)[2];</div></div><div><br></div><div>Why int?</div><div><br></div><div>Also, please strip trailing whitespace from your patch. We have too much of that already.</div></div><div><br></div><div>/jakob</div><div><br></div></div></body></html>