[llvm-commits] [llvm] r139148 - in /llvm/trunk: lib/Target/ARM/ARMInstrInfo.td test/CodeGen/ARM/atomic-cmp.ll test/CodeGen/ARM/atomic-op.ll

[Jakob Stoklund Olesen]

On Sep 6, 2011, at 11:01 AM, Eli Friedman wrote:

> On Tue, Sep 6, 2011 at 10:40 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>> Author: stoklund
>> Date: Tue Sep  6 12:40:35 2011
>> New Revision: 139148
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=139148&view=rev
>> Log:
>> Atomic pseudos don't use (as in read) CPSR. They clobber it.
> 
> Thanks for spotting that. :)

No problem. I blame English :-)

It is actually a good idea to add -verify-machineinstrs to this kind of test case. These days, the ARM backend is good enough that there isn't a ton of false positives. It's quite common for usesCustomInserter instructions to do something silly, and usually the verifier catches it.

/jakob