[llvm-commits] [llvm] r139148 - in /llvm/trunk: lib/Target/ARM/ARMInstrInfo.td test/CodeGen/ARM/atomic-cmp.ll test/CodeGen/ARM/atomic-op.ll

[Eli Friedman]

On Tue, Sep 6, 2011 at 10:40 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
> Author: stoklund
> Date: Tue Sep  6 12:40:35 2011
> New Revision: 139148
>
> URL: http://llvm.org/viewvc/llvm-project?rev=139148&view=rev
> Log:
> Atomic pseudos don't use (as in read) CPSR. They clobber it.

Thanks for spotting that. :)

-Eli

> Modified:
>    llvm/trunk/lib/Target/ARM/ARMInstrInfo.td
>    llvm/trunk/test/CodeGen/ARM/atomic-cmp.ll
>    llvm/trunk/test/CodeGen/ARM/atomic-op.ll
>
> Modified: llvm/trunk/lib/Target/ARM/ARMInstrInfo.td
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMInstrInfo.td?rev=139148&r1=139147&r2=139148&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/ARMInstrInfo.td (original)
> +++ llvm/trunk/lib/Target/ARM/ARMInstrInfo.td Tue Sep  6 12:40:35 2011
> @@ -1613,7 +1613,7 @@
>
>  // Atomic pseudo-insts which will be lowered to ldrexd/strexd loops.
>  // (These psuedos use a hand-written selection code).
> -let usesCustomInserter = 1, Uses = [CPSR] in {
> +let usesCustomInserter = 1, Defs = [CPSR] in {
>  def ATOMOR6432   : PseudoInst<(outs GPR:$dst1, GPR:$dst2),
>                               (ins GPR:$addr, GPR:$src1, GPR:$src2),
>                               NoItinerary, []>;
> @@ -4104,7 +4104,7 @@
>  }
>
>  let usesCustomInserter = 1 in {
> -  let Uses = [CPSR] in {
> +  let Defs = [CPSR] in {
>     def ATOMIC_LOAD_ADD_I8 : PseudoInst<
>       (outs GPR:$dst), (ins GPR:$ptr, GPR:$incr), NoItinerary,
>       [(set GPR:$dst, (atomic_load_add_8 GPR:$ptr, GPR:$incr))]>;
>
> Modified: llvm/trunk/test/CodeGen/ARM/atomic-cmp.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/atomic-cmp.ll?rev=139148&r1=139147&r2=139148&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/atomic-cmp.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/atomic-cmp.ll Tue Sep  6 12:40:35 2011
> @@ -1,5 +1,5 @@
> -; RUN: llc < %s -mtriple=armv7-apple-darwin   | FileCheck %s -check-prefix=ARM
> -; RUN: llc < %s -mtriple=thumbv7-apple-darwin | FileCheck %s -check-prefix=T2
> +; RUN: llc < %s -mtriple=armv7-apple-darwin -verify-machineinstrs   | FileCheck %s -check-prefix=ARM
> +; RUN: llc < %s -mtriple=thumbv7-apple-darwin -verify-machineinstrs | FileCheck %s -check-prefix=T2
>  ; rdar://8964854
>
>  define i8 @t(i8* %a, i8 %b, i8 %c) nounwind {
>
> Modified: llvm/trunk/test/CodeGen/ARM/atomic-op.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/atomic-op.ll?rev=139148&r1=139147&r2=139148&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/atomic-op.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/atomic-op.ll Tue Sep  6 12:40:35 2011
> @@ -1,5 +1,5 @@
> -; RUN: llc < %s -mtriple=armv7-apple-darwin10 | FileCheck %s
> -; RUN: llc < %s -mtriple=thumbv7-apple-darwin10 | FileCheck %s
> +; RUN: llc < %s -mtriple=armv7-apple-darwin10 -verify-machineinstrs | FileCheck %s
> +; RUN: llc < %s -mtriple=thumbv7-apple-darwin10 -verify-machineinstrs | FileCheck %s
>
>  define void @func(i32 %argc, i8** %argv) nounwind {
>  entry:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>