[llvm-commits] [llvm] r139005 - in /llvm/trunk: lib/Transforms/Scalar/GVN.cpp test/Transforms/GVN/pr10820.ll

Jakub Staszak jstaszak at apple.com
Fri Sep 2 07:57:37 PDT 2011


Author: kuba
Date: Fri Sep  2 09:57:37 2011
New Revision: 139005

URL: http://llvm.org/viewvc/llvm-project?rev=139005&view=rev
Log:
Compare type size instead of type _store_ size to make sure that BitCastInst
will be valid. This fixes PR10820.

Added:
    llvm/trunk/test/Transforms/GVN/pr10820.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/GVN.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/GVN.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/GVN.cpp?rev=139005&r1=139004&r2=139005&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/GVN.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/GVN.cpp Fri Sep  2 09:57:37 2011
@@ -689,8 +689,8 @@
   // If this is already the right type, just return it.
   Type *StoredValTy = StoredVal->getType();
   
-  uint64_t StoreSize = TD.getTypeStoreSizeInBits(StoredValTy);
-  uint64_t LoadSize = TD.getTypeStoreSizeInBits(LoadedTy);
+  uint64_t StoreSize = TD.getTypeSizeInBits(StoredValTy);
+  uint64_t LoadSize = TD.getTypeSizeInBits(LoadedTy);
   
   // If the store and reload are the same size, we can always reuse it.
   if (StoreSize == LoadSize) {

Added: llvm/trunk/test/Transforms/GVN/pr10820.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GVN/pr10820.ll?rev=139005&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/GVN/pr10820.ll (added)
+++ llvm/trunk/test/Transforms/GVN/pr10820.ll Fri Sep  2 09:57:37 2011
@@ -0,0 +1,17 @@
+; RUN: opt < %s -basicaa -gvn -S | FileCheck %s
+
+target datalayout =
+"e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-f128:128:128-n8:16:32:64"
+target triple = "x86_64-unknown-linux-gnu"
+
+ at g = external global i31
+
+define void @main() nounwind uwtable {
+entry:
+; CHECK: store i32
+  store i32 402662078, i32* bitcast (i31* @g to i32*), align 8
+  %0 = load i31* @g, align 8
+; CHECK: store i31
+  store i31 %0, i31* undef, align 1
+  unreachable
+}





More information about the llvm-commits mailing list