[llvm-commits] [llvm] r134907 - /llvm/trunk/utils/TableGen/

[David A. Greene]

Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

>> I've split up the patch.  The patch to constify Inits is mostly
>> mechanical but contains a few reworks of object construction due to the
>> elimination of various "set" methods in Inits.  I'll send it for review
>> as soon as I get everything updated and make sure it builds.
>

> Nobody wants to go through a large patch of chaff looking for
> meaningful changes. 

It's all meaningful.

> A patch that just adds some const qualifiers is very
> easy to review, on the other hand.

> That's what I meant by "… as long as it doesn't contain any other
> changes."

Constifying Init requires that I get rid of non-const methods.  These
are methods like BitsInit::setBit() that modify already-existing
objects.  Once those are gone, various pieces of code that create Inits
by cloning an existing Init and modifying it need to be updated to avoid
the modification.

                                -Dave