[llvm-commits] [llvm] r134907 - /llvm/trunk/utils/TableGen/

[Jakob Stoklund Olesen]

On Jul 12, 2011, at 4:36 PM, David A. Greene wrote:

> Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:
> 
>> A large patch with only mechanical changes is not a problem as long as
>> it doesn't contain any other changes.
> 
> Jakob,
> 
> I've split up the patch.  The patch to constify Inits is mostly
> mechanical but contains a few reworks of object construction due to the
> elimination of various "set" methods in Inits.  I'll send it for review
> as soon as I get everything updated and make sure it builds.

Nobody wants to go through a large patch of chaff looking for meaningful changes. You are not very likely to find a reviewer who wants to do that. A patch that just adds some const qualifiers is very easy to review, on the other hand.

That's what I meant by "… as long as it doesn't contain any other changes."

/jakob