[llvm-commits] [PATCH][Target/PTX] Add address_size directive to PTX backend

[Justin Holewinski]

On Jun 20, 2011, at 9:36 PM, 陳韋任 wrote:

>> I hate to nit-pick, but do we really need the address size field and associated enumeration?  It's always tied to the 64-bit flag, and we do not need to create any TableGen predicates from the value.
>> 
>> I think this patch can be as simple as:
>> 
>> if (ST.supportsPTX23()) {
>>  std::string addrSize = is64Bit() ? "64" : "32";
>>  OutStreamer.EmitRawText(Twine("\t.address_size " + addrSize));
>> }
> 
>  Done.

Looks good!  Committed in r133589.

> 
> Regards,
> chenwj
> 
> -- 
> Wei-Ren Chen (陳韋任)
> Computer Systems Lab, Institute of Information Science,
> Academia Sinica, Taiwan (R.O.C.)
> Tel:886-2-2788-3799 #1667
> <patch-llvm-133496.txt>

Thanks,

Justin Holewinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110621/a1105dbf/attachment.html>