<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 20, 2011, at 9:36 PM, 陳韋任 wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><blockquote type="cite">I hate to nit-pick, but do we really need the address size field and associated enumeration? It's always tied to the 64-bit flag, and we do not need to create any TableGen predicates from the value.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">I think this patch can be as simple as:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">if (ST.supportsPTX23()) {<br></blockquote><blockquote type="cite"> std::string addrSize = is64Bit() ? "64" : "32";<br></blockquote><blockquote type="cite"> OutStreamer.EmitRawText(Twine("\t.address_size " + addrSize));<br></blockquote><blockquote type="cite">}<br></blockquote><br> Done.<br></div></blockquote><div><br></div>Looks good! Committed in r133589.</div><div><br><blockquote type="cite"><div><br>Regards,<br>chenwj<br><br>-- <br>Wei-Ren Chen (陳韋任)<br>Computer Systems Lab, Institute of Information Science,<br>Academia Sinica, Taiwan (R.O.C.)<br>Tel:886-2-2788-3799 #1667<br><span><patch-llvm-133496.txt></span></div></blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: 'Lucida Grande'; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">Thanks,<br><br>Justin Holewinski</span>
</div>
<br></body></html>