[llvm-commits] [llvm] r132825 - /llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

[Eli Friedman]

On Thu, Jun 9, 2011 at 5:53 PM, Chad Rosier <mcrosier at apple.com> wrote:
> Author: mcrosier
> Date: Thu Jun  9 19:53:15 2011
> New Revision: 132825
>
> URL: http://llvm.org/viewvc/llvm-project?rev=132825&view=rev
> Log:
> Ensure that EmitGlobalVariable is correctly differentiating between declarations
> and definitions when emitting global variables.  This was causing global
> declarations to be emitted as if they were definitions.
> Fixes <rdar://problem/9429892>.

Testcase?

-Eli

> Modified:
>    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=132825&r1=132824&r2=132825&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Thu Jun  9 19:53:15 2011
> @@ -269,7 +269,7 @@
>   }
>
>   MCSymbol *GVSym = Mang->getSymbol(GV);
> -  EmitVisibility(GVSym, GV->getVisibility());
> +  EmitVisibility(GVSym, GV->getVisibility(), !GV->isDeclaration());
>
>   if (!GV->hasInitializer())   // External globals require no extra code.
>     return;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>