[llvm-commits] [llvm] r132825 - /llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

Chad Rosier mcrosier at apple.com
Thu Jun 9 17:53:15 PDT 2011


Author: mcrosier
Date: Thu Jun  9 19:53:15 2011
New Revision: 132825

URL: http://llvm.org/viewvc/llvm-project?rev=132825&view=rev
Log:
Ensure that EmitGlobalVariable is correctly differentiating between declarations
and definitions when emitting global variables.  This was causing global 
declarations to be emitted as if they were definitions.
Fixes <rdar://problem/9429892>.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=132825&r1=132824&r2=132825&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Thu Jun  9 19:53:15 2011
@@ -269,7 +269,7 @@
   }
 
   MCSymbol *GVSym = Mang->getSymbol(GV);
-  EmitVisibility(GVSym, GV->getVisibility());
+  EmitVisibility(GVSym, GV->getVisibility(), !GV->isDeclaration());
 
   if (!GV->hasInitializer())   // External globals require no extra code.
     return;





More information about the llvm-commits mailing list