[llvm-commits] [llvm] r132764 - in /llvm/trunk: lib/CodeGen/CallingConvLower.cpp test/CodeGen/X86/byval-align.ll

[Eric Christopher]

On Jun 8, 2011, at 11:38 PM, Eric Christopher wrote:

> 
> On Jun 8, 2011, at 11:37 PM, Cameron Zwarich wrote:
> 
>> On 2011-06-08, at 11:33 PM, Eric Christopher wrote:
>> 
>>> On Jun 8, 2011, at 11:29 PM, Eli Friedman wrote:
>>> 
>>>> On Wed, Jun 8, 2011 at 5:15 PM, Eric Christopher <echristo at apple.com> wrote:
>>>>> Author: echristo
>>>>> Date: Wed Jun  8 19:15:19 2011
>>>>> New Revision: 132764
>>>>> 
>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=132764&view=rev
>>>>> Log:
>>>>> If the alignment of the byval argument is greater than the alignment
>>>>> of the frame then increase the maximum alignment of the frame to
>>>>> match.
>>>>> 
>>>>> Fixes PR6965
>>>> 
>>>> I know it seems pretty strange, but this appears to be breaking the
>>>> http://google1.osuosl.org:8011/builders/llvm-gcc-native-mingw32-win7
>>>> buildbot...
>>> 
>>> Hmm.. I'd thought that was Cameron's patch when I saw it. I can revert
>>> to check though.
>> 
>> My patch affected opt, not llc, so it would be even more surprising if it caused the failure. :)
> 
> Heh. Good point. I was looking on my phone at the time ;)
> 
> Of course, I have no earthly clue how it could have broken the windows builder...

Wondering if it might have been r132758 and the builder was just confused.

-eric