[llvm-commits] Retail warnings in Mips lowering code

David Blaikie dblaikie at gmail.com
Wed Jun 8 18:42:18 PDT 2011


There's a couple of variables that are only used in asserts in the MIPS
lowering code (lib/Target/Mips/MipsISelLowering.cpp) - this causes warnings
in retail builds.

I've fixed both instances by rolling the relevant expression (they don't
appear to have any side effects) into the assert call & I added a comment in
the second case since it seemed like the name of the variable gave some
context/semantic information that wasn't necessarily entirely obvious from
the expression itself.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110608/895abe24/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mipswarnings.diff
Type: application/octet-stream
Size: 1233 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110608/895abe24/attachment.obj>


More information about the llvm-commits mailing list