[llvm-commits] Support for explicit argument form of X86 string instructions

[Chris Lattner]

On Mar 15, 2011, at 12:04 PM, Joerg Sonnenberger wrote:

>> 
>> Also, I think this can just be a static function, it doesn't need to
>> be a method on X86ATTAsmParser.  Likewise for the other predicates.
> 
> It does want to know if it is 32bit or 64bit mode. That's the only
> reason why it is in X86ATTAsmParser. Passing down the variable feels
> like a greater cludge.

Ah ok!

>> Instead of handling "lods" and "stos" in ParseInstruction, can't you
>> just ignore these two cases and let the suffix search code in
>> MatchAndEmitInstruction handle them?
> 
> MatchAndEmitInstruction and doesn't the register anymore, so it can't do
> that matching, I think. The actual instructions can't be used without
> suffix.

I'm not sure what you mean,

-Chris